Re: [PATCH 3/7] nfsd: remove redundant i_lookup check
From: Al Viro
Date: Sat Jul 23 2016 - 20:23:02 EST
On Fri, Jul 22, 2016 at 01:48:52PM -0400, J. Bruce Fields wrote:
> From: "J. Bruce Fields" <bfields@xxxxxxxxxx>
> I'm not sure why this was added. It doesn't seem necessary, and no
> other caller does this.
lookup_one_len() will explode if you call it for non-directory (==
!d_can_lookup(), i.e. something without ->lookup()). So unless the callers
do guarantee that check being true, it *is* needed.