Re: hwmon: xgene: Add support for X-Gene hwmon driver

From: Hoan Tran
Date: Sun Jul 24 2016 - 01:54:11 EST


Hi Itaru,

On Sat, Jul 23, 2016 at 10:04 PM, Itaru Kitayama
<itaru.kitayama@xxxxxxxx> wrote:
> Hi Hoan,
>
> I didn't mention in my previous post, though I think I'm using fairly recent
> version of Tianocore F/W, and I can confirm there's the PCCT table,
>
> [ 0.000000] ACPI: PCCT 0x00000047FA826000 000300 (v01 APM XGENE
> 00000003 01000013)
>
> is this still not enough? If that's the case, I'll talk to APM for
> their latest development Tianocore version.

Your version is missing the "pcc-channel" property of hwmon inside
ACPI Table. You need a newer version of Tianocore.

> Also, if you or your folks can fold your patch set into APM's xgene-next
> GitHub repo, that would help me to keep up with the development.

xgene-next is currently used for device tree patch only.

Thanks
Hoan

>
> Itaru
>
>
> On 7/24/16 12:00 PM, Hoan Tran wrote:
>>
>> You need the new firmware and BIOS which support ACPI PCC mailbox.
>>
>> Thanks
>> Hoan