Re: [PATCH] coresight: tmc: Delete an unnecessary check before the function call "kfree"

From: Mathieu Poirier
Date: Mon Jul 25 2016 - 12:36:30 EST


On 23 July 2016 at 12:08, SF Markus Elfring
<elfring@xxxxxxxxxxxxxxxxxxxxx> wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Sat, 23 Jul 2016 20:04:09 +0200
>
> The kfree() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/hwtracing/coresight/coresight-tmc-etf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-tmc-etf.c b/drivers/hwtracing/coresight/coresight-tmc-etf.c
> index e68289b..5fa49c4 100644
> --- a/drivers/hwtracing/coresight/coresight-tmc-etf.c
> +++ b/drivers/hwtracing/coresight/coresight-tmc-etf.c
> @@ -168,7 +168,7 @@ out:
> spin_unlock_irqrestore(&drvdata->spinlock, flags);
>
> /* Free memory outside the spinlock if need be */
> - if (!used && buf)
> + if (!used)
> kfree(buf);
>
> if (!ret)
> --
> 2.9.2
>

Applied - thanks.
Mathieu