Re: [PATCH] iio: adc: rockchip_saradc: Explicitly disable ADC on probe

From: Heiko Stübner
Date: Mon Jul 25 2016 - 15:42:20 EST


Am Montag, 25. Juli 2016, 12:39:00 schrieb Guenter Roeck:
> If the ADC is read for the first time, the caller gets a timeout error,
> and the kernel log shows
>
> read channel() error: -110
>
> The ADC may be enabled on boot, and needs to be explicitly disabled
> for a read sequence to work (otherwise there is no completion interrupt).
> Disaple it explicitly in the probe function.
>
> Fixes: 44d6f2ef94f9 ("iio: adc: add driver for Rockchip saradc")
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>

in my tests I hadn't notices that issue before, but that is likely because the
bootloaders I had didn't enable the saradc. Anyway, that looks definitly sane,
so

Reviewed-by: Heiko Stuebner <heiko@xxxxxxxxx>