RE: [PATCH v2] irqchip/qeic: move qeic driver from drivers/soc/fsl/qe

From: Qiang Zhao
Date: Mon Jul 25 2016 - 16:45:21 EST


On Thu, Jul 07, 2016 at 10:25PM , Jason Cooper <jason@xxxxxxxxxxxxxx> wrote:
> -----Original Message-----
> From: Jason Cooper [mailto:jason@xxxxxxxxxxxxxx]
> Sent: Thursday, July 07, 2016 10:25 PM
> To: Qiang Zhao <qiang.zhao@xxxxxxx>
> Cc: oss@xxxxxxxxxxxx; tglx@xxxxxxxxxxxxx; marc.zyngier@xxxxxxx; linuxppc-
> dev@xxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Xiaobo Xie
> <xiaobo.xie@xxxxxxx>
> Subject: Re: [PATCH v2] irqchip/qeic: move qeic driver from drivers/soc/fsl/qe
>
> Hi Zhao Qiang,
>
> On Thu, Jul 07, 2016 at 09:23:55AM +0800, Zhao Qiang wrote:
> > The driver stays the same.
> >
> > Signed-off-by: Zhao Qiang <qiang.zhao@xxxxxxx>
> > ---
> > Changes for v2:
> > - modify the subject and commit msg
> >
> > drivers/irqchip/Makefile | 1 +
> > drivers/{soc/fsl/qe => irqchip}/qe_ic.c | 0 drivers/{soc/fsl/qe =>
> > irqchip}/qe_ic.h | 0
> > drivers/soc/fsl/qe/Makefile | 2 +-
> > 4 files changed, 2 insertions(+), 1 deletion(-) rename
> > drivers/{soc/fsl/qe => irqchip}/qe_ic.c (100%) rename
> > drivers/{soc/fsl/qe => irqchip}/qe_ic.h (100%)
>
> Please merge the include file into the C file and rename to follow the naming
> convention in drivers/irqchip/. e.g. irq-qeic.c or irq-qe_ic.c.
>
> Once you have that, please resend the entire series with this as the first patch.

Sorry, I have no idea about "Include file", could you explain which file you meant?

Thank you!
-Zhao Qiang