Re: [Xen-devel] [PATCH linux v2 0/9] xen: pvhvm: support bootup on secondary vCPUs
From: Vitaly Kuznetsov
Date: Tue Jul 26 2016 - 04:28:39 EST
Stefano Stabellini <sstabellini@xxxxxxxxxx> writes:
> On Mon, 25 Jul 2016, Vitaly Kuznetsov wrote:
>> While we're not obliged to have the same type for xen_vcpu_id on all
>> arches I see no point in diverging without a reason. I can do v3 making
>> the mapping uint32
> I agree that making the mapping uint32_t would be desirable. It would
> even make sense from the int types point of view in Linux.
>>and indicating the missing value as U32_MAX-1 if nobody is against the
> Why U32_MAX-1? (int)-1 is (unsigned)U32_MAX. Even
> XEN_INVALID_MAX_VCPU_ID is defined as (~0U).
Yes, my bad, of course it should be U32_MAX.