Re: [PATCH] pnpbios: add header file to fix build errors

From: Rafael J. Wysocki
Date: Wed Jul 27 2016 - 19:45:01 EST


On Tuesday, July 26, 2016 04:26:40 PM Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>
> Fix build errors due to missing header file:
>
> ../drivers/pnp/pnpbios/core.c: In function 'pnp_dock_event':
> ../drivers/pnp/pnpbios/core.c:141:2: error: implicit declaration of function 'call_usermodehelper' [-Werror=implicit-function-declaration]
> value = call_usermodehelper(argv [0], argv, envp, UMH_WAIT_EXEC);
> ^
> ../drivers/pnp/pnpbios/core.c:141:52: error: 'UMH_WAIT_EXEC' undeclared (first use in this function)
> value = call_usermodehelper(argv [0], argv, envp, UMH_WAIT_EXEC);
> ^
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> ---
> I should have copied Rafael on this the first time.
> Also applies to mainline.

OK, I'm going to apply it, thanks!

> drivers/pnp/pnpbios/core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20160711.orig/drivers/pnp/pnpbios/core.c
> +++ linux-next-20160711/drivers/pnp/pnpbios/core.c
> @@ -60,6 +60,7 @@
> #include <linux/delay.h>
> #include <linux/acpi.h>
> #include <linux/freezer.h>
> +#include <linux/kmod.h>
> #include <linux/kthread.h>
>
> #include <asm/page.h>

--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.