Re: [PATCH] net/mlx5_core/pagealloc: Remove deprecated create_singlethread_workqueue
From: Saeed Mahameed
Date: Thu Jul 28 2016 - 18:46:23 EST
On Thu, Jul 28, 2016 at 12:37 PM, Leon Romanovsky <leonro@xxxxxxxxxxxx> wrote:
> On Thu, Jul 28, 2016 at 01:49:49PM +0530, Bhaktipriya Shridhar wrote:
>> A dedicated workqueue has been used since the work items are being used
>> on a memory reclaim path. WQ_MEM_RECLAIM has been set to guarantee forward
>> progress under memory pressure.
>> The workqueue has a single work item. Hence, alloc_workqueue() is used
>> instead of alloc_ordered_workqueue() since ordering is unnecessary when
>> there's only one work item.
>> Explicit concurrency limit is unnecessary here since there are only a
>> fixed number of work items.
>> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@xxxxxxxxx>
>> drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
> Hi Bhaktipriya,
> First of all, I would like to thank you for your work and invite you to
> continue, but can you please submit ONE patch SERIES which changes all
> similar places?
I agree with Leon, please push one series for all mlx5 patches and add
some explanation in the cover letter regarding the motivation of this
> Did you test this patch? Did you notice the memory reclaim path nature
> of this work?
>> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c b/drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c
>> index 9eeee05..7c85262 100644
>> --- a/drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c
>> +++ b/drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c
>> @@ -552,7 +552,8 @@ void mlx5_pagealloc_cleanup(struct mlx5_core_dev *dev)
>> int mlx5_pagealloc_start(struct mlx5_core_dev *dev)
>> - dev->priv.pg_wq = create_singlethread_workqueue("mlx5_page_allocator");
>> + dev->priv.pg_wq = alloc_workqueue("mlx5_page_allocator",
>> + WQ_MEM_RECLAIM, 0);
>> if (!dev->priv.pg_wq)
>> return -ENOMEM;
>> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at http://vger.kernel.org/majordomo-info.html