Re: [PATCH 1/2] ASoC: sunxi: Add bindings for sun6i to SPDIF

[Maxime Ripard]

On Sat, Jul 30, 2016 at 05:34:11PM +0200, Code Kipper wrote:
> On 30 July 2016 at 17:17, Maxime Ripard
> <maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote:
> > On Sat, Jul 30, 2016 at 04:27:15PM +0200, codekipper@xxxxxxxxx wrote:
> >> From: Marcus Cooper <codekipper@xxxxxxxxx>
> >>
> >> The A31 SoC uses the same SPDIF block as found in earlier SoCs, but its
> >> reset is controlled via a separate reset controller.
> >>
> >> Signed-off-by: Marcus Cooper <codekipper@xxxxxxxxx>
> >> ---
> >>  Documentation/devicetree/bindings/sound/sunxi,sun4i-spdif.txt | 3 +++
> >>  1 file changed, 3 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/sound/sunxi,sun4i-spdif.txt b/Documentation/devicetree/bindings/sound/sunxi,sun4i-spdif.txt
> >> index 13503aa..4fe80f7 100644
> >> --- a/Documentation/devicetree/bindings/sound/sunxi,sun4i-spdif.txt
> >> +++ b/Documentation/devicetree/bindings/sound/sunxi,sun4i-spdif.txt
> >> @@ -9,6 +9,7 @@ Required properties:
> >>
> >>    - compatible               : should be one of the following:
> >>      - "allwinner,sun4i-a10-spdif": for the Allwinner A10 SoC
> >> +    - "allwinner,sun6i-a31-spdif": for the Allwinner A31 SoC
> >>
> >>    - reg                      : Offset and length of the register set for the device.
> >>
> >> @@ -25,6 +26,8 @@ Required properties:
> >>       "apb"             clock for the spdif bus.
> >>       "spdif"           clock for spdif controller.
> >>
> >> +  - reset            : reset specifier for the ahb reset (A31 and newer only)
> >
> > Isn't it resets ? (plural)
> 
> Dohh..yes it is. Do you want me to send an updated patch series, a
> single patch change or could I beg for your commit massaging?

I'm not the one who is going to apply that patch, so I don't know :)

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Attachment: signature.asc
Description: PGP signature