RE: [PATCH v5 4/8] thunderbolt: Communication with the ICM (firmware)

From: Levy, Amir (Jer)
Date: Sun Jul 31 2016 - 08:07:51 EST


On Sat, Jul 30 2016, 12:03 AM, Stephen Hemminger wrote:
> On Thu, 28 Jul 2016 11:15:17 +0300
> Amir Levy <amir.jer.levy@xxxxxxxxx> wrote:
>
> > +int nhi_send_message(struct tbt_nhi_ctxt *nhi_ctxt, enum pdf_value
> pdf,
> > + u32 msg_len, const u8 *msg, bool ignore_icm_resp) {
>
> Why not make msg a void * and not have to do so many casts?

I couldn't agree more.