Re: [PATCH 2/3] phy: sun4i: add support for A64 usb phy

From: Amit Tomer
Date: Sun Jul 31 2016 - 08:58:28 EST


Hello ,

> @@ -264,6 +266,12 @@ static int sun4i_usb_phy_init(struct phy *_phy)
> val = readl(phy->pmu + REG_PMU_UNK_H3);
> writel(val & ~2, phy->pmu + REG_PMU_UNK_H3);
> } else {
> + /* A64 needs also this unknown bit */
> + if (data->cfg->type == sun50i_a64_phy) {
> + val = readl(phy->pmu + REG_PMU_UNK_H3);
> + writel(val & ~2, phy->pmu + REG_PMU_UNK_H3);
> + }
> +

This bit is also set for H3, shall we reuse it or we should enclose it
in else-if part ?

Thanks
Amit.