Re: [PATCH] mm: vmscan: fix memcg-aware shrinkers not called on global reclaim

From: Michal Hocko
Date: Mon Aug 01 2016 - 09:27:14 EST


On Mon 01-08-16 16:21:45, Vladimir Davydov wrote:
> On Mon, Aug 01, 2016 at 03:18:40PM +0200, Michal Hocko wrote:
> > On Mon 01-08-16 16:03:10, Vladimir Davydov wrote:
> > > We must call shrink_slab() for each memory cgroup on both global and
> > > memcg reclaim in shrink_node_memcg(). Commit d71df22b55099 accidentally
> > > changed that so that now shrink_slab() is only called with memcg != NULL
> > > on memcg reclaim. As a result, memcg-aware shrinkers (including
> > > dentry/inode) are never invoked on global reclaim. Fix that.
> > >
> > > Fixes: d71df22b55099 ("mm, vmscan: begin reclaiming pages on a per-node basis")
> >
> > I guess you meant b2e18757f2c9. I do not see d71df22b55099 anywhere.
>
> I'm basing on top of v4.7-mmotm-2016-07-28-16-33 and there it's
> d71df22b55099.

But this sha is unstable. THe patch you are referring to is already
sitting in the Linus tree so please use his (stable sha instead).
--
Michal Hocko
SUSE Labs