Re: [Xen-devel] [PATCH v2] xen: Make VPMU init message look less scary

From: Jan Beulich
Date: Tue Aug 02 2016 - 04:14:36 EST


>>> On 02.08.16 at 08:43, <JGross@xxxxxxxx> wrote:
> --- a/arch/x86/xen/pmu.c
> +++ b/arch/x86/xen/pmu.c
> @@ -547,8 +547,11 @@ void xen_pmu_init(int cpu)
> return;
>
> fail:
> - pr_info_once("Could not initialize VPMU for cpu %d, error %d\n",
> - cpu, err);
> + if (err == -EOPNOTSUPP)
> + pr_info_once("VPMU disabled by hypervisor.\n");
> + else
> + pr_info_once("Could not initialize VPMU for cpu %d, error %d\n",
> + cpu, err);

I'm sorry for not already having thought about this for v1, but
what about older hypervisors, where the hypercall would return
-ENOSYS?

Jan