[PATCH 0414/1285] Replace numeric parameter like 0444 with macro

From: Baole Ni
Date: Tue Aug 02 2016 - 07:47:59 EST


I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@xxxxxxxxx>
Signed-off-by: Baole Ni <baolex.ni@xxxxxxxxx>
---
drivers/media/i2c/msp3400-driver.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/media/i2c/msp3400-driver.c b/drivers/media/i2c/msp3400-driver.c
index e016626..a57ffe7 100644
--- a/drivers/media/i2c/msp3400-driver.c
+++ b/drivers/media/i2c/msp3400-driver.c
@@ -80,15 +80,15 @@ int msp_stereo_thresh = 0x190; /* a2 threshold for stereo/bilingual
(msp34xxg only) 0x00a0-0x03c0 */

/* read-only */
-module_param(opmode, int, 0444);
+module_param(opmode, int, S_IRUSR | S_IRGRP | S_IROTH);

/* read-write */
-module_param_named(once, msp_once, bool, 0644);
-module_param_named(debug, msp_debug, int, 0644);
-module_param_named(stereo_threshold, msp_stereo_thresh, int, 0644);
-module_param_named(standard, msp_standard, int, 0644);
-module_param_named(amsound, msp_amsound, bool, 0644);
-module_param_named(dolby, msp_dolby, bool, 0644);
+module_param_named(once, msp_once, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
+module_param_named(debug, msp_debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
+module_param_named(stereo_threshold, msp_stereo_thresh, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
+module_param_named(standard, msp_standard, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
+module_param_named(amsound, msp_amsound, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
+module_param_named(dolby, msp_dolby, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);

MODULE_PARM_DESC(opmode, "Forces a MSP3400 opmode. 0=Manual, 1=Autodetect, 2=Autodetect and autoselect");
MODULE_PARM_DESC(once, "No continuous stereo monitoring");
--
2.9.2