Re: [PATCH] perf tools: Fix build failture on perl script context

From: Arnaldo Carvalho de Melo
Date: Tue Aug 02 2016 - 11:10:34 EST


Em Tue, Aug 02, 2016 at 11:12:32AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Tue, Aug 02, 2016 at 11:03:02PM +0900, Namhyung Kim escreveu:
> > What I did to fix is adding '-Wno-shadow' as the error message said
> > it's the cause of the failure. Since it's from the perl (not perf)
> > code base, we don't have the control so I just wanted to ignore the
> > warning when compiling perl scripting code.
> >
> > Is it ok for you?
>
> Now it is :-)
>
> I'll stick this to the changeset log as the reason for adding
> -wno-shadow just for building the perl code.
>
> Sometimes we'll get to this conclusion after some thinking, if you add
> these explanations to the changelog then it speeds up reviewing.

Cool, this fixed the build as well for fedora rawhide.

- Arnaldo