Re: [PATCH] PM / devfreq: event: remove duplicate devfreq_event_get_drvdata()

From: Chanwoo Choi
Date: Thu Aug 04 2016 - 04:42:11 EST


+ Myungjoo Ham,

Hi Lin Huang,

On 2016ë 08ì 04ì 15:01, Lin Huang wrote:
> there define two devfreq_event_get_drvdata() function in devfreq-event.h
> when disable CONFIG_PM_DEVFREQ_EVENT, it will lead to build fail. So
> remove devfreq_event_get_drvdata() function.
>
> Signed-off-by: Lin Huang <hl@xxxxxxxxxxxxxx>
> ---
> include/linux/devfreq-event.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/include/linux/devfreq-event.h b/include/linux/devfreq-event.h
> index 0a83a1e..4db00b0 100644
> --- a/include/linux/devfreq-event.h
> +++ b/include/linux/devfreq-event.h
> @@ -148,11 +148,6 @@ static inline int devfreq_event_reset_event(struct devfreq_event_dev *edev)
> return -EINVAL;
> }
>
> -static inline void *devfreq_event_get_drvdata(struct devfreq_event_dev *edev)
> -{
> - return ERR_PTR(-EINVAL);
> -}
> -
> static inline struct devfreq_event_dev *devfreq_event_get_edev_by_phandle(
> struct device *dev, int index)
> {
>

Looks good to me.

Acked-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>

Regards,
Chanwoo Choi