Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac

[Andrew Donnellan]

On 05/08/16 08:58, York Sun wrote:
> Two symbols are missing if mpc85xx_edac driver is compiled as module.
>
> Signed-off-by: York Sun <york.sun@xxxxxxx>

Good catch! One comment below.

Reviewed-by: Andrew Donnellan <andrew.donnellan@xxxxxxxxxxx>

>  /*
>   * Reads the interrupt pin to determine if interrupt is use by card.
> @@ -1585,6 +1586,7 @@ int early_find_capability(struct pci_controller *hose, int bus, int devfn,
>  {
>  	return pci_bus_find_capability(fake_pci_bus(hose, bus), devfn, cap);
>  }
> +EXPORT_SYMBOL(early_find_capability);

It'd be nicer for this to be renamed as "pci_early_find_capability" or 
something like that with a "namespace", I think.


Andrew

--
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan@xxxxxxxxxxx  IBM Australia Limited