Re: [PATCH v2] powerpc/32: fix csum_partial_copy_generic()

From: Michael Ellerman
Date: Fri Aug 05 2016 - 05:39:53 EST


Christophe Leroy <christophe.leroy@xxxxxx> writes:

> Le 05/08/2016 Ã 08:57, Michael Ellerman a Ãcrit :
>> Alessio Igor Bogani <alessio.bogani@xxxxxxxxxx> writes:
>>> On 4 August 2016 at 05:53, Scott Wood <oss@xxxxxxxxxxxx> wrote:
>>>> On Tue, 2016-08-02 at 10:07 +0200, Christophe Leroy wrote:
>>>>> commit 7aef4136566b0 ("powerpc32: rewrite csum_partial_copy_generic()
>>>>> based on copy_tofrom_user()") introduced a bug when destination
>>>>> address is odd and initial csum is not null
>>>>>
>
> The purpose of this patch was not to address Alessio's issue, but to fix
> a huge issue on checksum calculation which induces breakdown of TCP
> connections.
>
> I think it is worth commiting it upstream and on impacted stable
> releases, allthought we don't have yet identified the issue Alessio's has.

OK. I'll put it back into fixes on Monday if I haven't heard anything
further.

cheers