Re: [PATCH V4 6/6] coresight: etm-perf: incorporating sink definition from cmd line

From: Mathieu Poirier
Date: Fri Aug 05 2016 - 11:44:22 EST


On 5 August 2016 at 03:32, Suzuki K Poulose <Suzuki.Poulose@xxxxxxx> wrote:
> On 04/08/16 17:53, Mathieu Poirier wrote:
>>
>> Now that PMU specific configuration is available as part of the event,
>> lookup the sink identified by users from the perf command line and build
>> a path from source to sink.
>>
>> With this functionality it is no longer required to select a sink in a
>> separate step (from sysFS) before a perf trace session can be started.
>>
>> Signed-off-by: Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>
>
>
>
>> +static const match_table_t drv_cfg_tokens = {
>> + {ETM_TOKEN_SINK_CPU, "sink=cpu%d:%s"},
>> + {ETM_TOKEN_SINK, "sink=%s"},
>> + {ETM_TOKEN_ERR, NULL},
>> +};
>> +
>
>
> Is the above format documented somewhere for the perf users ? If not could
> we please
> add it ?
>

Yes definitely. I will document everything once I am done with
upstreaming the feature. That way we go over the process only once.

> Thanks
> Suzuki
>