RE: [PATCH RFC V1] mfd: da9063: Update author information to remove incorrect e-mail addresses

From: Steve Twiss
Date: Mon Aug 08 2016 - 08:16:41 EST


On 8 August 2016 12:25, Lee Jones wrote:
> To: Steve Twiss
> Cc: LINUXKERNEL
> Subject: Re: [PATCH RFC V1] mfd: da9063: Update author information to remove incorrect e-mail addresses
>
> On Mon, 11 Jul 2016, Steve Twiss wrote:
> > From: Steve Twiss <stwiss.opensource@xxxxxxxxxxx>

[...]

> > Hi Lee,
> >
> > [...]
> > Unfortunately, there are several author entries in our source files with
> > Dialog Semiconductor e-mail addresses that are no longer valid. These
> > new changes I am proposing will erase the e-mail addresses without
> > affecting the author names.
> > [...]
>
> Hmm... I'm not sure how I feel about this. The email address provides
> us more then just contact information. I think the minimum format I
> will accept is:
>
> Krystian Garbaciak, Dialog Semiconductors

Yes, agreed. I should not remove the company name.
I will resend PATCH V2 with those changes

Regards,
Steve.

> > drivers/mfd/da9063-core.c | 6 +++---
> > drivers/mfd/da9063-i2c.c | 2 +-
> > drivers/mfd/da9063-irq.c | 2 +-
> > include/linux/mfd/da9063/core.h | 4 ++--
> > include/linux/mfd/da9063/pdata.h | 4 ++--
> > include/linux/mfd/da9063/registers.h | 4 ++--
> > 6 files changed, 11 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/mfd/da9063-core.c b/drivers/mfd/da9063-core.c
> > index af841c1..d011486 100644
> > --- a/drivers/mfd/da9063-core.c
> > +++ b/drivers/mfd/da9063-core.c
> > @@ -4,8 +4,8 @@
> > * Copyright 2012 Dialog Semiconductors Ltd.
> > * Copyright 2013 Philipp Zabel, Pengutronix
> > *
> > - * Author: Krystian Garbaciak <krystian.garbaciak@xxxxxxxxxxx>,
> > - * Michal Hajduk <michal.hajduk@xxxxxxxxxxx>
> > + * Author: Krystian Garbaciak
> > + * Author: Michal Hajduk
> > *
> > * This program is free software; you can redistribute it and/or modify it
> > * under the terms of the GNU General Public License as published by
> the
> > @@ -242,5 +242,5 @@ void da9063_device_exit(struct da9063 *da9063)
> > }
> >
> > MODULE_DESCRIPTION("PMIC driver for Dialog DA9063");
> > -MODULE_AUTHOR("Krystian Garbaciak
> <krystian.garbaciak@xxxxxxxxxxx>, Michal Hajduk
> <michal.hajduk@xxxxxxxxxxx>");
> > +MODULE_AUTHOR("Krystian Garbaciak, Michal Hajduk");
> > MODULE_LICENSE("GPL");
> > diff --git a/drivers/mfd/da9063-i2c.c b/drivers/mfd/da9063-i2c.c
> > index 7390108..54959be 100644
> > --- a/drivers/mfd/da9063-i2c.c
> > +++ b/drivers/mfd/da9063-i2c.c
> > @@ -3,7 +3,7 @@
> > * Copyright 2012 Dialog Semiconductor Ltd.
> > * Copyright 2013 Philipp Zabel, Pengutronix
> > *
> > - * Author: Krystian Garbaciak <krystian.garbaciak@xxxxxxxxxxx>
> > + * Author: Krystian Garbaciak
> > *
> > * This program is free software; you can redistribute it and/or modify it
> > * under the terms of the GNU General Public License as published by
> the
> > diff --git a/drivers/mfd/da9063-irq.c b/drivers/mfd/da9063-irq.c
> > index 7e903fc..230c813 100644
> > --- a/drivers/mfd/da9063-irq.c
> > +++ b/drivers/mfd/da9063-irq.c
> > @@ -3,7 +3,7 @@
> > * Copyright 2012 Dialog Semiconductor Ltd.
> > * Copyright 2013 Philipp Zabel, Pengutronix
> > *
> > - * Author: Michal Hajduk <michal.hajduk@xxxxxxxxxxx>
> > + * Author: Michal Hajduk
> > *
> > * This program is free software; you can redistribute it and/or modify it
> > * under the terms of the GNU General Public License as published by
> the
> > diff --git a/include/linux/mfd/da9063/core.h
> b/include/linux/mfd/da9063/core.h
> > index 621af82..6cc9e6c 100644
> > --- a/include/linux/mfd/da9063/core.h
> > +++ b/include/linux/mfd/da9063/core.h
> > @@ -3,8 +3,8 @@
> > *
> > * Copyright 2012 Dialog Semiconductor Ltd.
> > *
> > - * Author: Michal Hajduk <michal.hajduk@xxxxxxxxxxx>
> > - * Krystian Garbaciak <krystian.garbaciak@xxxxxxxxxxx>
> > + * Author: Michal Hajduk
> > + * Author: Krystian Garbaciak
> > *
> > * This program is free software; you can redistribute it and/or modify it
> > * under the terms of the GNU General Public License as published by
> the
> > diff --git a/include/linux/mfd/da9063/pdata.h
> b/include/linux/mfd/da9063/pdata.h
> > index 612383b..b4201de 100644
> > --- a/include/linux/mfd/da9063/pdata.h
> > +++ b/include/linux/mfd/da9063/pdata.h
> > @@ -3,8 +3,8 @@
> > *
> > * Copyright 2012 Dialog Semiconductor Ltd.
> > *
> > - * Author: Michal Hajduk <michal.hajduk@xxxxxxxxxxx>
> > - * Author: Krystian Garbaciak <krystian.garbaciak@xxxxxxxxxxx>
> > + * Author: Michal Hajduk
> > + * Author: Krystian Garbaciak
> > *
> > * This program is free software; you can redistribute it and/or modify it
> > * under the terms of the GNU General Public License as published by
> the
> > diff --git a/include/linux/mfd/da9063/registers.h
> b/include/linux/mfd/da9063/registers.h
> > index 2e0ba6d..2c34286 100644
> > --- a/include/linux/mfd/da9063/registers.h
> > +++ b/include/linux/mfd/da9063/registers.h
> > @@ -3,8 +3,8 @@
> > *
> > * Copyright 2012 Dialog Semiconductor Ltd.
> > *
> > - * Author: Michal Hajduk <michal.hajduk@xxxxxxxxxxx>
> > - * Krystian Garbaciak <krystian.garbaciak@xxxxxxxxxxx>
> > + * Author: Michal Hajduk
> > + * Author: Krystian Garbaciak
> > *
> > * This program is free software; you can redistribute it and/or modify it
> > * under the terms of the GNU General Public License as published by
> the
>
> --
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org â Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog