Re: [PATCH] mfd: syscon: Make use of of_iomap

From: Lee Jones
Date: Tue Aug 09 2016 - 08:56:32 EST


On Sun, 07 Aug 2016, Andrey Smirnov wrote:

> Use of_iomap instead of explicitly calling of_address_to_resource() and
> ioremap().
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx>
> ---
> drivers/mfd/syscon.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c
> index 2f2225e..55b883d 100644
> --- a/drivers/mfd/syscon.c
> +++ b/drivers/mfd/syscon.c
> @@ -59,12 +59,7 @@ static struct syscon *of_syscon_register(struct device_node *np)
> if (!syscon)
> return ERR_PTR(-ENOMEM);
>
> - if (of_address_to_resource(np, 0, &res)) {
> - ret = -ENOMEM;
> - goto err_map;
> - }
> -
> - base = ioremap(res.start, resource_size(&res));
> + base = of_iomap(np, 0);
> if (!base) {
> ret = -ENOMEM;
> goto err_map;

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog