Re: 4.8-rc1: resume from hibernation doesn't work

From: Pavel Machek
Date: Tue Aug 09 2016 - 16:11:19 EST


On Tue 2016-08-09 10:54:15, Jiri Kosina wrote:
> On Tue, 9 Aug 2016, Jiri Kosina wrote:
>
> > current Linus' tree (HEAD 65ea11ec6, so basically 4.8-rc1+) has broken
> > resume from hibernation on my x200s.
> >
> > Suspend works correctly, resuming proceeds up to the point where it
> > reports 100% of reading of the hibernation image, and afterwards the
> > machine reboots (tripple fault ... dunno, I don't really see any kernel
> > messages between the report of reading the hibernation image and reboot).
> >
> > 4.7-rc4 is fine on this machine, so I thought I'd bisect it, but
> > unfortunately at some point in the bisection process, the hibernation
> > itself breaks, so there is not really a way for me to bisect it.
> >
> > Any ideas which patches to try to revert?
>
> Okay, turning off CONFIG_RANDOMIZE_MEMORY makes the problem go away and
> machine resumes properly (and yes, I am running a kernel that already
> contains c226fab474).
>
> Adding Thomas Garnier to CC as well.

64-bit kernel, I assume?

I believe that is known:

From: "Rafael J. Wysocki" <rafael@xxxxxxxxxx>
To: Thomas Garnier <thgarnie@xxxxxxxxxx>
Cc: "Rafael J. Wysocki" <rafael@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxx>, "Rafael J. Wysocki"
<rjw@xxxxxxxxxxxxx>, Linux PM list <linux-pm@xxxxxxxxxxxxxxx>, the arch/x86 maintainers
<x86@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Yinghai Lu
<yinghai@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar
<mingo@xxxxxxxxxx>, "H . Peter Anvin" <hpa@xxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>,
Pavel Machek <pavel@xxxxxx>, Kernel Hardening <kernel-hardening@xxxxxxxxxxxxxxxxxx>,
Borislav Petkov <bpetkov@xxxxxxx>
Subject: Re: [Resend][PATCH] x86/power/64: Always create temporary identity mapping correctly
...

>>>> Suggested-by: Yinghai Lu <yinghai@xxxxxxxxxx>
>>>> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
>>>> Acked-by: Yinghai Lu <yinghai@xxxxxxxxxx>
>>>> ---
>>>>
>>>> This is sort of urgent, because hibernation doesn't work with KASLR on x86-64
>>>> in 4.8-rc1 AFAICS and this should make them work together again.
>>>>
>>>> Unless anyone sees any problems with it, I'll queue it up for 4.8-rc2.
>>>>
>>>> Thomas, would it be possible to test it with KASLR enabled, please?

So yes, testing the patch from that thread would be helpful.

Thanks,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html