Re: [PATCH resend v3 3/5] libata-scsi: use u8 array to store mode page copy

From: Tejun Heo
Date: Tue Aug 09 2016 - 16:13:58 EST


On Sat, Jul 23, 2016 at 02:34:08AM +0800, tom.ty89@xxxxxxxxx wrote:
> From: Tom Yan <tom.ty89@xxxxxxxxx>
>
> ata_mselect_*() would initialize a char array for storing a copy of
> the current mode page. However, char could be signed char. In that
> case, bytes larger than 127 would be converted to negative number.
>
> For example, 0xff from def_control_mpage[] would become -1. This
> prevented ata_mselect_control() from working at all, since when it
> did the read-only bits check, there would always be a mismatch.
>
> Signed-off-by: Tom Yan <tom.ty89@xxxxxxxxx>

Applied to libata/for-4.9.

Thanks.

--
tejun