Re: [PATCH v2 0/5] Allow the trampoline to use EFI boot services RAM

From: Ingo Molnar
Date: Wed Aug 10 2016 - 15:07:11 EST



One side note:

* Andy Lutomirski <luto@xxxxxxxxxx> wrote:

> This series fixes it the other way: it allow the trampoline to live
> in boot services memory. It achieves this by deferring the panic
> due to failure to reserve a trampoline until early_initcall time
> and then adjusting the EFI boot services quirk to reserve space
> for the trampoline if we haven't already found it a home.

> x86/efi: Allocate a trampoline if needed in efi_free_boot_services()

Btw., this means that we first try to allocate the trampoline the old fashioned
way, and in the rare cases this fails we allocate it from the EFI data area,
right?

This is problematic from the probability management POV: we are creating a rare
piece of code that will run only on a select few systems.

I think it would be much better to allocate the trampoline from the EFI area on
all EFI systems by default. Is there any reason why that would not work?

Thanks,

Ingo