Re: [PATCH] x86/smp: Fix __max_logical_packages value setup

From: Peter Zijlstra
Date: Thu Aug 11 2016 - 09:47:08 EST


On Thu, Aug 11, 2016 at 03:05:21PM +0200, Jiri Olsa wrote:
> hum, so we either need some acpi solution to get number of all
> sockets or

This.. So the problem here is that the BIOS completely screws us over.

It wrecks the ACPI-ID table with that option to limit the number of CPUs
exposed to the OS (note that it didn't need to do that, it could have
enumerated them as empty, instead of not there at all) while keeping the
CPUID of the CPUs as reporting they have many (12? was it) cores.

This results in inconsistent state, and we're left with nothing useful.

> fix the uncore code to initialize pmu boxes on cpu hotplug as well

Can't.. it uses the boxes at STARTING time, and we can't do allocs
there. Not can we alloc earlier, because we don't know max_packages is
going to increase.