Re: [PATCH] eeprom: at24: check if the chip is functional in probe()

From: Wolfram Sang
Date: Thu Aug 11 2016 - 11:55:46 EST


> >> + err = at24_read(at24, 0, &c, 1);
> >
> > Can't we do this before registering dummy clients and nvmem registration?
> >
>
> It should be ok for nvmem, but I'm not sure about the clients:
> at24_translate_offset() will return one of the registered client
> structures and though it should generally work for the first byte (it
> would always be at24->client[0]), it won't be "rock solid" anymore.

Agreed.

Attachment: signature.asc
Description: PGP signature