Re: [PATCH] ses: Fix racy cleanup of /sys in remove_dev()

From: James Bottomley
Date: Fri Aug 12 2016 - 13:45:17 EST


On Thu, 2016-07-28 at 21:23 -0400, Martin K. Petersen wrote:
> > > > > > "Calvin" == Calvin Owens <calvinowens@xxxxxx> writes:
>
> > > Any thoughts? Squinting at this more it still seems racy, but a
> > > narrow race is surely better than just blatantly freeing
> > > everything
> > > while the file is still exposed in /sys? Is there a better way
> > > you'd
> > > prefer I accomplish this?
> > >
> > > (I have boxes that OOPS all the time from monitoring code reading
> > > the
> > > /sys files, with this patch I haven't seen a single one.)
>
> Calvin> Ping? Thoughts, comments?
>
> James: This is your puppy...

I thought it would be bigger by now going by the early paw size
indicator ...

Anyway

Reviewed-by: James Bottomley <jejb@xxxxxxxxxxxxxxxxxx>

James