Re: [PATCH net 2/4] hv_netvsc: reset vf_inject on VF removal

From: David Miller
Date: Fri Aug 12 2016 - 23:41:20 EST


From: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>
Date: Thu, 11 Aug 2016 12:58:55 +0200

> We reset vf_inject on VF going down (netvsc_vf_down()) but we don't on
> VF removal (netvsc_unregister_vf()) so vf_inject stays 'true' while
> vf_netdev is already NULL and we're trying to inject packets into NULL
> net device in netvsc_recv_callback() causing kernel to crash.
>
> Signed-off-by: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>

You can't create a blocking operation problem knowingly in this
patch just because you fix it in patch #4.

You must order your patches such that the driver does not regress
at any intermediate stage of your patch series.