Re: [PATCH v3 32/51] x86/dumpstack: simplify in_exception_stack()

From: Andy Lutomirski
Date: Sun Aug 14 2016 - 04:41:57 EST


On Fri, Aug 12, 2016 at 7:28 AM, Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:
> in_exception_stack() does some bad, bad things just so the unwinder can
> print different values for different areas of the debug exception stack.
>
> There's no need to clarify where exactly on the stack it is. Just print
> "#DB" and be done with it.

I'm okay with the printing part, but you're also using this to prevent
infinite looping. Will this cause the unwind to fail if we go debug
-> page fault -> debug or similar? (Or whatever actually uses the
deeper debug stacks? I figured this out once and then forgot exactly
what's going on. I really need to dust off my patches that stop using
IST for #DB.)

--Andy