Re: [PATCH] block: Fix secure erase

From: Adrian Hunter
Date: Tue Aug 16 2016 - 03:25:19 EST


On 15/08/16 21:14, Christoph Hellwig wrote:
> On Mon, Aug 15, 2016 at 11:43:12AM -0500, Shaun Tancheff wrote:
>> Hmm ... Since REQ_SECURE implied REQ_DISCARD doesn't this
>> mean that we should include REQ_OP_SECURE_ERASE checking
>> wherever REQ_OP_DISCARD is being checked now in drivers/scsi/sd.c ?
>>
>> (It's only in 3 spots so it's a quickie patch)
>
> SCSI doesn't support secure erase operations. Only MMC really
> supports it, plus the usual cargo culting in Xen blkfront that's
> probably never been tested..
>

I left SCSI out because support does not exist at the moment.
However there is UFS which is seen as the replacement for eMMC.
And there is a patch to add support for BLKSECDISCARD:

http://marc.info/?l=linux-scsi&m=146953519016056

So SCSI will need updating if that is to go in.