Re: [PATCH v2 03/10] usb: ulpi: use new api functions if available

From: Heikki Krogerus
Date: Tue Aug 16 2016 - 06:55:33 EST


Hi,

On Mon, Aug 01, 2016 at 09:15:51PM +0300, Tal Shorer wrote:
> If the registered has the new api callbacks {read|write}_dev, call
> these instead of the deprecated read, write functions. If the
> registered does not support the new callbacks, revert to calling the
> old ones as before.
>
> Signed-off-by: Tal Shorer <tal.shorer@xxxxxxxxx>
> ---
> drivers/usb/common/ulpi.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/common/ulpi.c b/drivers/usb/common/ulpi.c
> index d1f419c..a877ddb 100644
> --- a/drivers/usb/common/ulpi.c
> +++ b/drivers/usb/common/ulpi.c
> @@ -21,13 +21,17 @@
>
> int ulpi_read(struct ulpi *ulpi, u8 addr)
> {
> - return ulpi->ops->read(ulpi->ops, addr);
> + if (!ulpi->ops->read_dev)
> + return ulpi->ops->read(ulpi->ops, addr);
> + return ulpi->ops->read_dev(ulpi->dev.parent, addr);
> }
> EXPORT_SYMBOL_GPL(ulpi_read);
>
> int ulpi_write(struct ulpi *ulpi, u8 addr, u8 val)
> {
> - return ulpi->ops->write(ulpi->ops, addr, val);
> + if (!ulpi->ops->write_dev)
> + return ulpi->ops->write(ulpi->ops, addr, val);
> + return ulpi->ops->write_dev(ulpi->dev.parent, addr, val);
> }
> EXPORT_SYMBOL_GPL(ulpi_write);
>
> --
> 2.7.4

Squash patches 2-3 into one patch.

Thanks,

--
heikki