[RFC PATCH v2 1/4] usb: typec: Do not check if connected when setting roles

From: Guenter Roeck
Date: Wed Aug 17 2016 - 18:04:52 EST


The connection status can change after the connection status was
checked. Leave it up to the driver to perform the necessary checks.

Signed-off-by: Guenter Roeck <groeck@xxxxxxxxxxxx>
---
v2: Rebased to v5 of Type-C class code

drivers/usb/typec/typec.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/drivers/usb/typec/typec.c b/drivers/usb/typec/typec.c
index 52a0431253a8..fa0261dad3b7 100644
--- a/drivers/usb/typec/typec.c
+++ b/drivers/usb/typec/typec.c
@@ -785,9 +785,6 @@ current_data_role_store(struct device *dev, struct device_attribute *attr,
return -EOPNOTSUPP;
}

- if (!port->connected)
- return size;
-
ret = sysfs_strmatch(typec_data_roles, ARRAY_SIZE(typec_data_roles),
buf);
if (ret < 0)
@@ -851,9 +848,6 @@ static ssize_t current_power_role_store(struct device *dev,
return -EIO;
}

- if (!port->connected)
- return size;
-
ret = sysfs_strmatch(typec_roles, ARRAY_SIZE(typec_roles), buf);
if (ret < 0)
return ret;
--
2.8.0.rc3.226.g39d4020