Re: [PATCH] usb: remove redundant dependency on USB_SUPPORT

From: Felipe Balbi
Date: Thu Aug 18 2016 - 03:04:11 EST



Hi,

Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> writes:
> 2016-08-16 16:29 GMT+09:00 Felipe Balbi <balbi@xxxxxxxxxx>:
>>
>> Hi,
>>
>> Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> writes:
>>> The whole Kconfig entries of the USB subsystem are surrounded with
>>> "if USB_SUPPORT" ... "endif", so CONFIG_USB_SUPPORT=y is surely met
>>> when these two Kconfig options are visible.
>>>
>>> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
>>> ---
>>>
>>> drivers/usb/core/Kconfig | 1 -
>>> drivers/usb/dwc3/Kconfig | 2 +-
>>> 2 files changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig
>>> index dd28010..253aac7 100644
>>> --- a/drivers/usb/core/Kconfig
>>> +++ b/drivers/usb/core/Kconfig
>>> @@ -85,7 +85,6 @@ config USB_OTG_FSM
>>>
>>> config USB_ULPI_BUS
>>> tristate "USB ULPI PHY interface support"
>>> - depends on USB_SUPPORT
>>> help
>>> UTMI+ Low Pin Interface (ULPI) is specification for a commonly used
>>> USB 2.0 PHY interface. The ULPI specification defines a standard set
>>> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
>>> index 11864e4..3c6213c 100644
>>> --- a/drivers/usb/dwc3/Kconfig
>>> +++ b/drivers/usb/dwc3/Kconfig
>>> @@ -1,7 +1,7 @@
>>> config USB_DWC3
>>> tristate "DesignWare USB3 DRD Core Support"
>>> depends on (USB || USB_GADGET) && HAS_DMA
>>> - select USB_XHCI_PLATFORM if USB_SUPPORT && USB_XHCI_HCD
>>> + select USB_XHCI_PLATFORM if USB_XHCI_HCD
>>> help
>>> Say Y or M here if your system has a Dual Role SuperSpeed
>>> USB controller based on the DesignWare USB3 IP Core.
>>
>> let's split this patch in two so different maintainers can pick the
>> relevant pieces. Thanks
>
>
> Greg picked up this patch already.
>
> I see it in linux-next now.

oh, okay. No problem

--
balbi

Attachment: signature.asc
Description: PGP signature