Re: [PATCH v9 2/2] PCI: Rockchip: Add Rockchip PCIe controller support

From: Bjorn Helgaas
Date: Thu Aug 18 2016 - 21:01:22 EST


Hi Shawn,

On Thu, Aug 04, 2016 at 03:52:08PM +0800, Shawn Lin wrote:
> This patch adds Rockchip PCIe controller support found
> on RK3399 Soc platform.

> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -264,4 +264,15 @@ config PCIE_ARTPEC6
> Say Y here to enable PCIe controller support on Axis ARTPEC-6
> SoCs. This PCIe controller uses the DesignWare core.
>
> +config PCIE_ROCKCHIP
> + bool "Rockchip PCIe controller"
> + depends on ARM64 && ARCH_ROCKCHIP

I don't see any actual ARM64 dependencies in the code (which is a very
good thing!). Can we remove the "depends on ARM64" part?

> + depends on OF
> + depends on PCI_MSI_IRQ_DOMAIN
> + select MFD_SYSCON
> + help
> + Say Y here if you want internal PCI support on Rockchip SoC.
> + There is 1 internal PCIe port available to support GEN2 with
> + 4 slots.