Re: [PATCH] staging: lustre: llite: don't clean in_data again

From: Oleg Drokin
Date: Sat Aug 20 2016 - 23:39:18 EST


Acked-by: Oleg Drokin <oleg.drokin@xxxxxxxxx>

On Aug 20, 2016, at 10:44 PM, Shawn Lin wrote:

> We have got a zero buffer for in_data as we use
> kzalloc here. So let's remove it anyway.
>
> Signed-off-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>
> ---
>
> drivers/staging/lustre/lustre/llite/file.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/llite/file.c b/drivers/staging/lustre/lustre/llite/file.c
> index 50938bd..ec6b7ce 100644
> --- a/drivers/staging/lustre/lustre/llite/file.c
> +++ b/drivers/staging/lustre/lustre/llite/file.c
> @@ -3251,7 +3251,6 @@ void *ll_iocontrol_register(llioc_callback_t cb, int count, unsigned int *cmd)
> if (!in_data)
> return NULL;
>
> - memset(in_data, 0, sizeof(*in_data));
> in_data->iocd_size = size;
> in_data->iocd_cb = cb;
> in_data->iocd_count = count;
> --
> 2.3.7
>