Re: [PATCH -next] drm/i915: Fix non static symbol warning

From: Jani Nikula
Date: Mon Aug 22 2016 - 09:03:29 EST


On Sun, 21 Aug 2016, Wei Yongjun <weiyj.lk@xxxxxxxxx> wrote:
> From: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
>
> Fixes the following sparse warning:
>
> drivers/gpu/drm/i915/intel_hotplug.c:480:6: warning:
> symbol 'i915_hpd_poll_init_work' was not declared. Should it be static?
>
> Also move the '{' to new line.

Thanks for the patch, but we've already fixed this in

commit 24808e96792a860f3e83e2eb69c5190261716924
Author: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
Date: Wed Aug 17 12:09:06 2016 +0100

drm/i915: Mark i915_hpd_poll_init_work as static

BR,
Jani.

>
> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
> ---
> drivers/gpu/drm/i915/intel_hotplug.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_hotplug.c b/drivers/gpu/drm/i915/intel_hotplug.c
> index 5dc2c20..334d47b 100644
> --- a/drivers/gpu/drm/i915/intel_hotplug.c
> +++ b/drivers/gpu/drm/i915/intel_hotplug.c
> @@ -477,7 +477,8 @@ void intel_hpd_init(struct drm_i915_private *dev_priv)
> spin_unlock_irq(&dev_priv->irq_lock);
> }
>
> -void i915_hpd_poll_init_work(struct work_struct *work) {
> +static void i915_hpd_poll_init_work(struct work_struct *work)
> +{
> struct drm_i915_private *dev_priv =
> container_of(work, struct drm_i915_private,
> hotplug.poll_init_work);
>

--
Jani Nikula, Intel Open Source Technology Center