Re: [PATCH v05 08/72] rds.h: use __u8, __u16, __s16, __u32 and __s64 from linux/types.h

From: Mikko Rapeli
Date: Tue Aug 23 2016 - 16:46:33 EST


On Mon, Aug 22, 2016 at 02:52:58PM -0400, Sowmini Varadhan wrote:
> On (08/22/16 20:32), Mikko Rapeli wrote:
> >
> > Fixes userspace compilation errors like:
> >
> > linux/rds.h:96:2: error: unknown type name âuint8_tâ
> >
> > Signed-off-by: Mikko Rapeli <mikko.rapeli@xxxxxx>
>
> Acked-by: Sowmini Varadhan <sowmini.varadhan@xxxxxxxxxx>
>
> I think we discussed this some time before, and I certainly
> dont have any religious opinions about it, but I would like
> to point out that this means that the exported rds.h will
> expose __<type> to user space applications.

Thanks. I'm also not religious but patches to include <stdint.h> in userspace
side were previously rejected with arguments like
https://lkml.org/lkml/2015/6/1/160

Thus I've been sending linux/types.h conversion patches.

-Mikko