Re: [PATCH 09/10] reset: zynq: add driver Kconfig option

[Philipp Zabel]

Am Donnerstag, den 25.08.2016, 16:31 +0900 schrieb Masahiro Yamada:
> 2016-08-25 16:23 GMT+09:00 Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>:
> > Am Donnerstag, den 25.08.2016, 10:08 +0900 schrieb Masahiro Yamada:
> >> 2016-08-25 2:48 GMT+09:00 Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>:
> >> > 2016-08-24 22:29 GMT+09:00 Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>:
> >> >> Visible only if COMPILE_TEST is enabled, this allows to include the
> >> >> driver in build tests.
> >> >>
> >> >> Cc: Moritz Fischer <moritz.fischer@xxxxxxxxx>
> >> >> Cc: Michal Simek <michal.simek@xxxxxxxxxx>
> >> >> Cc: SÃren Brinkmann <soren.brinkmann@xxxxxxxxxx>
> >> >> Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> >> >> ---
> >> >>  drivers/reset/Kconfig  | 6 ++++++
> >> >>  drivers/reset/Makefile | 2 +-
> >> >>  2 files changed, 7 insertions(+), 1 deletion(-)
> >> >>
> >> >> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> >> >> index 17030e2..86b49a2 100644
> >> >> --- a/drivers/reset/Kconfig
> >> >> +++ b/drivers/reset/Kconfig
> >> >> @@ -67,6 +67,12 @@ config RESET_SUNXI
> >> >>         help
> >> >>           This enables the reset driver for Allwinner SoCs.
> >> >>
> >> >> +config RESET_ZYNQ
> >> >> +       bool "ZYNQ Reset Driver" if COMPILE_TEST
> >> >> +       default ARCH_ZYNQ
> >> >> +       help
> >> >> +         This enables the reset driver for Xilinx Zynq FPGAs.
> >> >> +
> >> >
> >> > Please move this below RESET_UNIPHIER
> >> > as I assume you are sorting Kconfig entries alphabetically.
> >
> > Yes, that was my intention.
> >
> >> > Otherwise,
> >> >
> >> > Reviewed-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> >> >
> >>
> >>
> >>
> >>
> >> >> +         This enables the reset driver for Xilinx Zynq FPGAs.
> >>
> >>
> >> One more thing, I thought this statement is not precise
> >> because Zynq is not only an FPGA,
> >> but ARM SoC + FPGA.
> >>
> >> Please consider to reword
> >>
> >> "This enables the reset driver for Xilinx Zynq SoC"
> >
> > I'll change it to SoCs, thanks.
> 
> Maybe singular?   As far as I know, Zynq-7000 is the only SoC
> of the Zynq family.
> I am not sure if Xilinx has plan to add more lineups to 32bit SoCs.

Zynq-7000 is a family, so plural should be okay.

regards
Philipp