Re: [PATCH 2/5] Drivers: hv: balloon: account for gaps in hot add regions
From: Vitaly Kuznetsov
Date: Thu Aug 25 2016 - 08:14:51 EST
Yauheni Kaliuta <yauheni.kaliuta@xxxxxxxxxx> writes:
> Hi, kys!
>
>>>>>> On Wed, 24 Aug 2016 16:23:10 -0700, kys wrote:
>
> [...]
>
> > -static bool pfn_covered(unsigned long start_pfn, unsigned long pfn_cnt)
> > +static int pfn_covered(unsigned long start_pfn, unsigned long pfn_cnt)
> > {
> > struct list_head *cur;
> > struct hv_hotadd_state *has;
> > + struct hv_hotadd_gap *gap;
> > unsigned long residual, new_inc;
>
> > if (list_empty(&dm_device.ha_region_list))
>
> One "return false;" left here.
>
This is removed in patch 4/5 of this series and false is 0 anyway)
[...]
--
Vitaly