Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only open

From: Jiri Kosina
Date: Thu Aug 25 2016 - 11:16:40 EST


On Thu, 25 Aug 2016, Jens Axboe wrote:

> Which patch is this? If that is truly the case, it should be reverted
> asap.

I've been looking into this for the past few days, and unfortunately I am
not able to come up with a simple fix, so revert seems like the way to go.

Unfortunately, by reverting the patch, we'll get back into the original
situation, where the bug found by syzkaller would be present.

If going down the revert path, we'd have to bring the driver to the state
it was before, i.e. reverting it and the followup fix, i.e.

ff06db1efb2ad6db06eb5b99b88a0c15a9cc9b0e
09954bad448791ef01202351d437abdd9497a804

And then go back to the drawing board to fix the corruption reported by
syzkaller.

--
Jiri Kosina
SUSE Labs