Re: [RESEND PATCH] staging: octeon: Use IS_ENABLED() instead of checking for built-in or module
From: Javier Martinez Canillas
Date: Thu Aug 25 2016 - 18:56:26 EST
On 08/25/2016 12:01 PM, David Daney wrote:
> On 08/25/2016 06:55 AM, Javier Martinez Canillas wrote:
>> The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
>> built-in or as a module, use that macro instead of open coding the same.
>> Using the macro makes the code more readable by helping abstract away some
>> of the Kconfig built-in and module enable details.
>> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
>> Acked-by: David Daney <david.daney@xxxxxxxxxx>
>> Changes since first post:
>> - Added David Daney Acked-by tag.
>> - Rebased on top of latest master.
> You changed something about the patch. In this case the Subject is not "RESEND", but rather "v2". Incorrect Subject lines like this can lead to the patch being inadvertently ignored.
Yes, in fact I thought about adding a v2 suffix instead of RESEND but since
I didn't change the patch content (besides merge conflicts resolution), I
preferred to add the latter.
I can re-spin the patch if that's an issue.
> David Daney
Javier Martinez Canillas
Open Source Group
Samsung Research America