[PATCH 1/1] ASoC: Intel: Atom: add a missing star in a memcpy call

From: Nicolas Iooss
Date: Sun Aug 28 2016 - 13:40:50 EST


In sst_prepare_and_post_msg(), when a response is received in "block",
the following code gets executed:

*data = kzalloc(block->size, GFP_KERNEL);
memcpy(data, (void *) block->data, block->size);

The memcpy() call overwrites the content of the *data pointer instead of
filling the newly-allocated memory (which pointer is hold by *data).
Fix this by using *data in the memcpy() call.

Fixes: 60dc8dbacb00 ("ASoC: Intel: sst: Add some helper functions")
Cc: stable@xxxxxxxxxxxxxxx # 3.19.x
Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@xxxxxxx>
---
sound/soc/intel/atom/sst/sst_pvt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/intel/atom/sst/sst_pvt.c b/sound/soc/intel/atom/sst/sst_pvt.c
index adb32fefd693..7c398b7c9d4b 100644
--- a/sound/soc/intel/atom/sst/sst_pvt.c
+++ b/sound/soc/intel/atom/sst/sst_pvt.c
@@ -289,7 +289,7 @@ int sst_prepare_and_post_msg(struct intel_sst_drv *sst,
ret = -ENOMEM;
goto out;
} else
- memcpy(data, (void *) block->data, block->size);
+ memcpy(*data, (void *) block->data, block->size);
}
}
out:
--
2.9.3