Re: [PATCH 1/2] Documentation: mmc: sdhci-of-arasan: add description of power domain

From: Ziyuan Xu
Date: Sun Aug 28 2016 - 20:37:25 EST

On 2016å08æ27æ 22:50, Shawn Lin wrote:
On 2016/8/27 21:41, Ziyuan Xu wrote:
Add power domain as a optional property for sdhci-of-arasan, which can
be truned off in the so-called unused condition, such as suspend and
remove. Aim to lower power requirements.

Signed-off-by: Ziyuan Xu <xzy.xu@xxxxxxxxxxxxxx>


Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
index 3404afa..3f5189c 100644
--- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
+++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
@@ -1,12 +1,14 @@
Device Tree Bindings for the Arasan SDHCI Controller

- The bindings follow the mmc[1], clock[2], interrupt[3] and phy[4] bindings.
+ The bindings follow the mmc[1], clock[2], interrupt[3], phy[4] and power
+ domain[5] bindings.
Only deviations are documented here.

[1] Documentation/devicetree/bindings/mmc/mmc.txt
[2] Documentation/devicetree/bindings/clock/clock-bindings.txt
[3] Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
[4] Documentation/devicetree/bindings/phy/phy-bindings.txt
+ [5] Documentation/devicetree/bindings/power/power_domain.txt

Required Properties:
- compatible: Compatibility string. One of:
@@ -36,6 +38,8 @@ Optional Properties:
- #clock-cells: If specified this should be the value <0>. With this property
in place we will export a clock representing the Card Clock. This clock
is expected to be consumed by our PHY. You must also specify
+ - power-domains: A phandle of and PM domain as specifier defined by bindings

A phandle of what?

That's a typo.

+ of the power controller specified by phandle.

sdhci@e0100000 {

It would be nice to add the example code.

Okay, I will show a sample code in V2.

Thanks, shawn.