Re: [PATCH] acer-wmi: only supports AMW0_GUID1 on acer family

From: BjÃrn Mork
Date: Mon Aug 29 2016 - 06:15:55 EST


"Lee, Chun-Yi" <joeyli.kernel@xxxxxxxxx> writes:

> The AMW0_GUID1 wmi is not only found on Acer family but also other
> machines like Lenovo, Fujitsu and Medion. In the past days, acer-wmi
> driver handled those non-Acer machines by quirks list.
>
> But actually acer-wmi driver was loaded on any machines that have
> AMW0_GUID1. This behavior is strange because those machines should
> be supported by appropriate wmi drivers. e.g. fujitsu-laptop,
> ideapad-laptop.
>
> So, This patch adds the logic to check the machine that has AMW0_GUID1
> should be in Acer/Packard Bell/Gateway white list. But, it still keeps
> the quirk list of those supported non-acer machines for backward
> compatible.

Works fine for me on a Lenovo Thinkpad X1 Carbon 4th gen. Thanks.

Bogus accelerometer device without patch:

acer_wmi: Acer Laptop ACPI-WMI Extras
input: Acer BMA150 accelerometer as /devices/virtual/input/input16

With patch:

acer_wmi: Acer Laptop ACPI-WMI Extras
acer_wmi: Unsupported machine has AMW0_GUID1, unable to load


So if you want it:

Tested-by: BjÃrn Mork <bjorn@xxxxxxx>