Re: [PATCH v2 7/8] pinctrl: Add pinctrl-aspeed-g5 driver

From: Joel Stanley
Date: Tue Aug 30 2016 - 02:05:34 EST


2016-08-19 22:14 GMT+09:30 Andrew Jeffery <andrew@xxxxxxxx>:
> A small subset of pins and functions are exposed. The selection of pins
> and functions is driven by the development of OpenBMC[1] on the
> AST2500 SoC, particularly around booting the IBM Witherspoon platform.
>
> [1] https://github.com/openbmc/docs
>
> Signed-off-by: Andrew Jeffery <andrew@xxxxxxxx>

As with the g4 driver, this looks good and works fine on the
ast2500evb and witherspoon boards.

Reviewed-by: Joel Stanley <joel@xxxxxxxxx>

> ---
>
> Since v1:
>
> * Fix the RMII1 signal descriptor bit
> * Add a number of new mux function and pin definitions
> * Sort the pin, group and function arrays for sanity
> * Add SoC-specific compatible string
>
> drivers/pinctrl/aspeed/Kconfig | 8 +
> drivers/pinctrl/aspeed/Makefile | 1 +
> drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c | 808 +++++++++++++++++++++++++++++
> 3 files changed, 817 insertions(+)
> create mode 100644 drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c