Re: [PATCH][v8] PM / hibernate: Verify the consistent of e820 memory map by md5 value

From: Rafael J. Wysocki
Date: Tue Aug 30 2016 - 07:45:36 EST


On Monday, August 29, 2016 03:41:23 PM Borislav Petkov wrote:
> On Mon, Aug 29, 2016 at 09:15:00AM +0200, Pavel Machek wrote:
> > Sounds about as easy as hot unplugging arbitrary memory address. IOW
> > "not easy".
>
> Regardless, forcibly panicking the system more is still the wrong
> approach IMO.

Agreed.

> Instead, I'd try to issue a big fat warning that BIOS corrupts E820 and
> that the user should disable hibernation on that box and never ever
> enable it again.
>
> After that, the kernel should *disable* hibernation for the current boot
> so any further hibernation runs don't even happen. Maybe even taint
> itself.

Yes, taint the kernel when e820 mismatch is detected.

It may be a good idea to start an emergency shutdown in that case too, but
after getting to a point when it actually has a chance to work.

Thanks,
Rafael