Re: [PATCH v4] brcmfmac: add missing header dependencies
From: Kalle Valo
Date: Tue Aug 30 2016 - 12:08:45 EST
Baoyou Xie <baoyou.xie@xxxxxxxxxx> writes:
> On 29 August 2016 at 23:31, RafaÅ MiÅecki <zajec5@xxxxxxxxx> wrote:
> On 29 August 2016 at 14:39, Baoyou Xie <baoyou.xie@xxxxxxxxxx> wrote:
> > We get 1 warning when build kernel with W=1:
> > drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c:23:6:
> warning: no previous prototype for '__brcmf_err' [-Wmissing-prototypes]
> building? I'm not native English, but I think so.
> > In fact, this function is declared in brcmfmac/debug.h, so this patch
> > add missing header dependencies.
> > Signed-off-by: Baoyou Xie <baoyou.xie@xxxxxxxxxx>
> > Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
> Please don't resend patches just to add tags like that. This only
> increases a noise and patchwork handles this just fine, see:
> Do I need to resend a patch that fixes two typos(build/add)? or you modify them
> on your way?
I can fix those when I commit the patch.