Re: [PATCH v4 2/3] tracing: Add trace_irqsoff tracepoints

From: Binoy Jayan
Date: Wed Aug 31 2016 - 07:39:28 EST


Hi Steven/Daniel,

On 30 August 2016 at 19:38, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>> +
>> + TP_printk("ltype=%d, latency=%lu",
>> + __entry->ltype, (unsigned long) __entry->latency)
>
> The print of ltype should be text and not a number. Well, you could
> have both text and a number, but a number is useless for those looking
> at traces.

I am using '__print_symbolic' to display ltype as a string but it
still shows up in
the histogram as a number. Would you suggest to change this as well?

Thanks,
Binoy