Re: [RESEND PATCH v2] memory-hotplug: fix store_mem_state() return value

From: Reza Arbab
Date: Wed Aug 31 2016 - 20:18:09 EST


On Wed, Aug 31, 2016 at 05:03:25PM -0700, David Rientjes wrote:
Nope, the return value of changing state from online to online was
established almost 11 years ago in commit 3947be1969a9.

Fair enough. So if online-to-online is -EINVAL,
1. Shouldn't 'echo 1 > online' then also return -EINVAL?

2. store_mem_state() still needs a tweak, right? It was only returning -EINVAL by accident, due to the convoluted sequence I listed in the patch.

--
Reza Arbab