Re: [PATCH] ASoC: omap-pcm: off-by-one in 'omap_pcm_limit_supported_formats'

From: Peter Ujfalusi
Date: Thu Sep 01 2016 - 03:01:21 EST


On 09/01/16 09:52, Christophe JAILLET wrote:
> When calling 'snd_pcm_format_physical_width', SNDRV_PCM_FORMAT_LAST is a
> valid value, so don't skip it.

Acked-by: Peter Ujfalusi <peter.ujfalusi@xxxxxx>

> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> ---
> Un-tested
> ---
> sound/soc/omap/omap-pcm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c
> index a84f677234f0..94e9ff791f3a 100644
> --- a/sound/soc/omap/omap-pcm.c
> +++ b/sound/soc/omap/omap-pcm.c
> @@ -58,7 +58,7 @@ static void omap_pcm_limit_supported_formats(void)
> {
> int i;
>
> - for (i = 0; i < SNDRV_PCM_FORMAT_LAST; i++) {
> + for (i = 0; i <= SNDRV_PCM_FORMAT_LAST; i++) {
> switch (snd_pcm_format_physical_width(i)) {
> case 8:
> case 16:
>


--
Péter